-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMware: restore timeout in set_vm_power_state operation #47723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'state_change_timeout' parameter was removed, this introduced regression. Fixes: ansible#47722 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Hi @Akasurde, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
cloud
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
vmware
VMware community
labels
Oct 28, 2018
Akasurde
removed
the
needs_triage
Needs a first human triage before being processed.
label
Oct 28, 2018
Tested and works as expected! |
Akasurde
added a commit
to Akasurde/ansible
that referenced
this pull request
Oct 29, 2018
'state_change_timeout' parameter was removed, this introduced regression. Fixes: ansible#47722 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit a87a62b)
Akasurde
added a commit
to Akasurde/ansible
that referenced
this pull request
Oct 29, 2018
'state_change_timeout' parameter was removed, this introduced regression. Fixes: ansible#47722 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit a87a62b)
abadger
pushed a commit
that referenced
this pull request
Oct 31, 2018
mattclay
pushed a commit
that referenced
this pull request
Nov 6, 2018
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
'state_change_timeout' parameter was removed, this introduced regression. Fixes: ansible#47722 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
cloud
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
support:community
This issue/PR relates to code supported by the Ansible community.
vmware
VMware community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
'state_change_timeout' parameter was removed, this introduced
regression.
Fixes: #47722
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/47722-vmware_guest_powerstate-restore_timeout.yaml
lib/ansible/modules/cloud/vmware/vmware_guest_powerstate.py
ANSIBLE VERSION